Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates compiler error E0040 with new format #35357

Merged
merged 1 commit into from
Aug 7, 2016
Merged

Conversation

shri3k
Copy link
Contributor

@shri3k shri3k commented Aug 5, 2016

Addresses #35208 as part of #35233.
r? @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

Thanks!

Can you update the corresponding test file in compile-fail directory please?

@shri3k
Copy link
Contributor Author

shri3k commented Aug 5, 2016

Yeah, it seems I forgot to update that on both of my PRs. I'll go ahead and update this later tonight. Thank you for catching it. 😳

@shri3k
Copy link
Contributor Author

shri3k commented Aug 6, 2016

I was able to find only one test file corresponding to this error. Updated it.

r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 6, 2016

📌 Commit e5a4a7a has been approved by GuillaumeGomez

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Updates compiler error E0040 with new format

Addresses rust-lang#35208 as part of rust-lang#35233.
r? @GuillaumeGomez
@@ -20,5 +20,7 @@ impl Drop for Foo {

fn main() {
let mut x = Foo { x: -7 };
x.drop(); //~ ERROR E0040
x.drop();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace on this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. 😅 Sorry.

@sanxiyn
Copy link
Member

sanxiyn commented Aug 7, 2016

@bors r-

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2016

📌 Commit b564c6a has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Updates compiler error E0040 with new format

Addresses rust-lang#35208 as part of rust-lang#35233.
r? @GuillaumeGomez
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Updates compiler error E0040 with new format

Addresses rust-lang#35208 as part of rust-lang#35233.
r? @GuillaumeGomez
bors added a commit that referenced this pull request Aug 7, 2016
@bors bors merged commit b564c6a into rust-lang:master Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants