-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates compiler error E0040 with new format #35357
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks! Can you update the corresponding test file in compile-fail directory please? |
Yeah, it seems I forgot to update that on both of my PRs. I'll go ahead and update this later tonight. Thank you for catching it. 😳 |
I was able to find only one test file corresponding to this error. Updated it. |
Thanks! @bors: r+ rollup |
📌 Commit e5a4a7a has been approved by |
Updates compiler error E0040 with new format Addresses rust-lang#35208 as part of rust-lang#35233. r? @GuillaumeGomez
@@ -20,5 +20,7 @@ impl Drop for Foo { | |||
|
|||
fn main() { | |||
let mut x = Foo { x: -7 }; | |||
x.drop(); //~ ERROR E0040 | |||
x.drop(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace on this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. 😅 Sorry.
@bors r- |
@bors r+ rollup |
📌 Commit b564c6a has been approved by |
Updates compiler error E0040 with new format Addresses rust-lang#35208 as part of rust-lang#35233. r? @GuillaumeGomez
Updates compiler error E0040 with new format Addresses rust-lang#35208 as part of rust-lang#35233. r? @GuillaumeGomez
Addresses #35208 as part of #35233.
r? @GuillaumeGomez